[VL] Patch Window freezes

velcrome · July 9, 2017, 11:25pm

I can reproduce this in my little setup.

As soon as I create an Operations node in another Operations node, the vl gui freezes.
I get two exceptions (in a very awkward exception dialog, btw. copypaste is a pain)

gist.github.com

https://gist.github.com/anonymous/6626e04e05629cc51544b41fca41fb7f

gistfile1.txt

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at VL.Lang.View.CanvasView.ConnectionMouseHandler.MouseMove(VMouseEventArgs arg) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\ConnectionMouseHandler.cs:line 415
   at VL.Lang.View.CanvasView.ConnectionMouseHandler.FKeyboardHandler_KeyDownEvent(Object sender, VKeyEventArgs e) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\ConnectionMouseHandler.cs:line 443
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at VL.Lang.View.DefaultKeyEventHandler.KeyDown(Object sender, VKeyEventArgs arg) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\MouseHandlerBase.cs:line 205
   at VL.HDE.PatchEditor.EditorControl.ProcessKeyPreview(Message& m) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EditorControl.cs:line 654

This file has been truncated. show original

gist.github.com

https://gist.github.com/anonymous/6626e04e05629cc51544b41fca41fb7f

gistfile1.txt

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at VL.Lang.View.CanvasView.ConnectionMouseHandler.MouseMove(VMouseEventArgs arg) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\ConnectionMouseHandler.cs:line 415
   at VL.Lang.View.CanvasView.ConnectionMouseHandler.FKeyboardHandler_KeyDownEvent(Object sender, VKeyEventArgs e) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\ConnectionMouseHandler.cs:line 443
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at VL.Lang.View.DefaultKeyEventHandler.KeyDown(Object sender, VKeyEventArgs arg) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EventHandler\MouseHandlerBase.cs:line 205
   at VL.HDE.PatchEditor.EditorControl.ProcessKeyPreview(Message& m) in C:\BuildAgent\work\95074898639d5736\vvvv50\VL.UI\src\VL Forms\PatchEditor\EditorControl.cs:line 654

This file has been truncated. show original

when I click continue, the gui is completely unresponsive, after a few seconds the next exception hits.
Cannot delete the faulty node, or have any other way of recovery except killing vvvv process.

Use this to reproduce:
zeromq.zip (99.9 KB)

velcrome · July 15, 2017, 10:20pm

Using beta35.8 and alpha35.8 alongside, I suspect a probable cause.

In the official node17 release, such a problem cannot occur, because placing an operation into an operation would probably fail gracefully, and complaining with “Recursion not allowed yet”.

Only the alpha (to my understanding an unmerged branch) allows dll import, but misses some of the safeguarding the master branch already has included.

Please correct me if I am wrong.

And please allow such constructs, using other member operations or utility operations within the same scope is a no-brainer. If you are afraid of recursion (good call before we have a node stepper in vl), check for circular references, but don’t restrict all calls just on suspicion.

tonfilm · July 17, 2017, 1:05pm

thanks, tracked

Elias · August 1, 2017, 2:27pm

Thank you for the report velcrome. The crash should not occur anymore and using other operations defined in the same patch should work now as long as they’re not recursive. I’ve added a stripped down version of your patch to the tests making use of that kind of code structuring / call hierarchy.

velcrome · August 1, 2017, 4:19pm

This is great to hear. Glad that report helped you

system · August 1, 2018, 4:29pm

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.